This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Fix ArtifactId::path #3027
Merged
Fix ArtifactId::path #3027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepyakin
added
A0-please_review
pepyakin
approved these changes
May 15, 2021
pepyakin
added
the
D3-trivial 🧸
gavofyork
approved these changes
May 15, 2021
bkchr
approved these changes
May 15, 2021
crystalin
pushed a commit
to moonbeam-foundation/polkadot
that referenced
this pull request
May 17, 2021
* issue with ArtifactId::path * fix artifacts path * Wrap an overly long line Co-authored-by: Sergei Shulepov <s.pepyakin@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the default behavior of display, which I don't think is what we want
https://github.com/paritytech/parity-common/blob/0867e488f6567e0d7fe13e78a14797ff019033f7/fixed-hash/src/hash.rs#L219-L227
cc @bkchr @pepyakin